Implement Search in Peregrine

[jimbo]

Description

Primary changes

• Rewrite SearchBar and its subcomponents to use hooks
• Extract some functionality into custom hooks
• Add custom hooks to peregrine (listed below)

Other changes

• Upgrade informed from 1.10.12 to 2.1.13
• Fix components and tests after upgrading informed
• Upgrade react-apollo from 2.4.1 to 2.5.3
• List react-apollo as a peer dependency of peregrine
• Upgrade react-test-renderer from 16.8.3 to 16.8.6
• List react-test-renderer as a dev dependency of peregrine
• Create a utility to wrap TestRenderer.create() with act()
• Export mergeClasses from classify
• Fix Jest config for CI

New custom hooks

Hook	Role
useApolloContext	Get Apollo client from context
useDocumentListener	Add an event listener on mount; remove it on unmount
useDropdown	Manage dropdown component state
useQuery	Get a callback to perform an Apollo query and its results
useQueryResult	Manage Apollo query result state
useValueFromSearchParams	Call a callback (e.g., setValue) with the value of a search param

File overview

Type	Count
component	9
custom hook	6
utility	5
index/adapter	3
style	6
test	16
mock	2
snapshot	7
package	3
config	1

Related Issue

Closes #1062.

Motivation and Context

We're starting to move some Venia components to Peregrine, and in the process we'll be extracting as much of their functionality as possible into hooks. Peregrine currently doesn't share a lot of dependencies with Venia, but it's going to have to pick some of them up as a result of this work.

Here's the big question: given a Venia component, should we extract all of its functionality (i.e., everything before the return statement) into a custom hook and move that hook into Peregrine? If we do, end users can use the hook to render fully custom structure, similar to render props. Just like render props, though, the API of such a hook (what inputs it expects, and what output it returns) would be unique, so you'd have to consult documentation or source code to use it. Also, naming such a hook can be challenging.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[supernova-at]

Looked over the recent changes, I think it looks great.

I resolved all of my conversations that warranted it, so there's only a few outstanding questions / issues that folks had.

Feel free to resolve conversations, if I had a question on whether something had been resolved or not I left it open to be safe.

[zetlen]

Thanks for the clarifications. I understand your listener hooks better now. The only reason I'm not approving this is followups on two comments for small renames/reorgs. Everything else looks great.

[zetlen]

@jimbo What do you think of changing this hook's name?

[zetlen]

@jimbo Is it safe to delete this utility since it's in Peregrine now?

[jimbo]

Regarding the name of useValueFromSearchParams(): yes, we can rename it. What should we call it, given that it accepts a param (key), retrieves the corresponding value from search params, and calls a callback, setValue(), with that value?

Regarding createTestInstance(): yes, we can change the Venia tests to use the version from Peregrine.

[zetlen]

@jimbo How about useUrlSearchParameters?

Requested changes have been made.