Refactor Header component to function #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-supernova-979header.magento-research1.now.sh |
supernova-at
force-pushed
the
supernova/979_header
branch
from
1e95ef8 to
afe2761
Compare
sirugh
reviewed
May 15, 2019
| get searchIcon() { | ||
| return <Icon src={SearchIcon} />; | ||
| } | ||
| const SearchBar = React.lazy(() => import('src/components/SearchBar')); |
There was a problem hiding this comment.
I'm new to React.lazy. How can I see that this is indeed lazily loading? What affect should it have in the browser? I'm not seeing a new chunk/request being made which is confusing me :D
sirugh
approved these changes
May 15, 2019
zetlen
pushed a commit
that referenced
this pull request
May 23, 2019
feat: centralize configuration fixup porting lambda to new config fixup config management from sender, not receiver refactor: Configuration class docs: unified config doc draft
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Header/header.jscomponent to be a function instead of a class.It was part of the transition to Peregrine / Hooks, but this component is very simple and doesn't need to make use of any hooks at all. As a result, nothing was moved to Peregrine in this PR.
Related Issue
Closes #979 .
Verification Steps
How Have YOU Tested this?
yarn testScreenshots / Screen Captures (if appropriate):
The Header component:
Proposed Labels for Change Type/Package
Checklist: