-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[bug]: Incorrect Order Id Displayed - Replacing functionality #1249
Conversation
…ls button for authed users
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-bugfix-receiptcontent.magento-research1.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and functions as expected. Suggested some minor cleanup we can do of legacy code that will clean this component up a little.
packages/venia-concept/src/components/Checkout/Receipt/receipt.js
Outdated
Show resolved
Hide resolved
packages/venia-concept/src/components/Checkout/Receipt/receipt.js
Outdated
Show resolved
Hide resolved
packages/venia-concept/src/components/Checkout/Receipt/receipt.js
Outdated
Show resolved
Hide resolved
packages/venia-concept/src/components/Checkout/Receipt/receipt.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some clarification to one unresolved comment, everything else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
@sirugh "...by creating and account" should it be "...by creating an account" , typo? |
packages/venia-concept/src/components/Checkout/Receipt/receipt.js
Outdated
Show resolved
Hide resolved
...s/venia-concept/src/components/Checkout/Receipt/__tests__/__snapshots__/receipt.spec.js.snap
Outdated
Show resolved
Hide resolved
…__/__snapshots__/receipt.spec.js.snap
@dpatil-magento fixed |
QA Pass. Waiting for #20 to get merged. |
Description
Receipt
to be a functional component.Related Issue
Closes #816.
Verification Steps
How Have YOU Tested this?
Verification steps above!
Screenshots / Screen Captures (if appropriate):
Proposed Labels for Change Type/Package
Checklist: