-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[bug]: Load JS resources from root #1257
[bug]: Load JS resources from root #1257
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-fork-niklas-wolf-js-resource-fix.magento-research1.now.sh |
@@ -24,5 +24,5 @@ | |||
{{> templates/default-font-include}} | |||
<link rel="preconnect" href="{{env.MAGENTO_BACKEND_URL}}"> | |||
{{#bundles.prefetch}} | |||
<link rel="prefetch script" href="{{.}}"> | |||
<link rel="prefetch script" href="/{{.}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are provided by the asset-manifest
which is created by the webpack asset manifest plugin. This plugin provides a publicPath
prop which we should be using to prepend the forward slash rather than hardcoding in the templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check in a productionized env but this works locally.
Description
JS resources now get loaded from root of the application.
Related Issue
Closes #1256 .
Verification Steps
Verification can be done by following the steps described in the issue. The page should now load correctly.
How Have YOU Tested this?
see verification steps
Screenshots / Screen Captures (if appropriate):
Proposed Labels for Change Type/Package
Checklist: