Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: Load JS resources from root #1257

Merged
merged 4 commits into from
Jun 4, 2019

Conversation

mothership-nik-wolf
Copy link
Contributor

Description

JS resources now get loaded from root of the application.

Related Issue

Closes #1256 .

Verification Steps

Verification can be done by following the steps described in the issue. The page should now load correctly.

How Have YOU Tested this?

see verification steps

Screenshots / Screen Captures (if appropriate):

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@magento-cicd2
Copy link

magento-cicd2 commented May 20, 2019

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented May 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-fork-niklas-wolf-js-resource-fix.magento-research1.now.sh

@sirugh sirugh self-assigned this Jun 4, 2019
@sirugh sirugh changed the title Load JS resources from root [bug]: Load JS resources from root Jun 4, 2019
@sirugh sirugh added the bug Something isn't working label Jun 4, 2019
@@ -24,5 +24,5 @@
{{> templates/default-font-include}}
<link rel="preconnect" href="{{env.MAGENTO_BACKEND_URL}}">
{{#bundles.prefetch}}
<link rel="prefetch script" href="{{.}}">
<link rel="prefetch script" href="/{{.}}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are provided by the asset-manifest which is created by the webpack asset manifest plugin. This plugin provides a publicPath prop which we should be using to prepend the forward slash rather than hardcoding in the templates.

Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double check in a productionized env but this works locally.

@dpatil-magento dpatil-magento merged commit a99702e into magento:develop Jun 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: JS-Resources can't be loaded on subcategories
5 participants