-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[docs]: Add federated search to docs #1280
[docs]: Add federated search to docs #1280
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-fork-belbiy-ybadd-federated-search.magento-research1.now.sh |
This is on hold until @belbiy is ready to make this feature live on all doc sites |
LogERROR ON TASK: prettierCheck
|
@jcalcaben , i'm ready to merge this if you don't mind. What's the next steps to do this? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@dpatil-magento here are the verification steps I used:
- Check out the latest from
develop
git fetch origin && git checkout origin/develop
- Pull in the changes for this PR:
git pull https://github.com/belbiy/pwa-studio.git yb_add-federated-search
- Install new ruby dependencies
bundle install
- Install any new node dependencies
npm install
- Run preview server
npm run develop
- Navigate to the home page.
- Type in a term in the search box such as "rest"
- Verify that multiple results from the different devdoc sites appear
- Submit the search term
- Verify that you are on the search results page with the search results grouped in different tabs.
Description
This PR adds the federated search feature to the docs site. You now can search for Devdocs, User Guide and OMS docs from PWA docs.
I would also like to commit Gemfile.lock file as we do on devdocs, since it's better way to manage the updates to theme and other gems this way.
Verification Steps
How Have YOU Tested this?
Screenshots / Screen Captures (if appropriate):
Proposed Labels for Change Type/Package
Checklist: