Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUGFIX] Solved 404 links for 'Edit this page on GitHub' #1302

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

lewisvoncken
Copy link
Contributor

Description

The 'Edit this page on GitHub' for the Upward Tutorial 404 page is resolved

https://magento-research.github.io/pwa-studio/tutorials/hello-upward/simple-server/

Screenshots / Screen Captures (if appropriate):

image

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented Jun 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-fork-lewisvoncken-patch-2.magento-research1.now.sh

@jcalcaben jcalcaben removed their assignment Jun 7, 2019
@jcalcaben
Copy link
Contributor

Validation steps

  1. Navigate to the pwa-devdocs directory
  2. Start the preview server npm run develop
  3. Navigate to tutorials/hello-upward/simple-server/ and the other UPWARD tutorials
  4. Click on 'Edit this page on GitHub' on the right column
  5. Verify the link does not result in a 404 response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants