Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Header: Replace Suspense Fallback for SearchBar #1351

Merged
merged 6 commits into from
Jun 20, 2019

Conversation

tjwiebell
Copy link
Contributor

Description

Fix edge case scenario on slow devices where Suspense temporarily loads a fallback component while the SearchBar component is being loaded.

Related Issue

Closes #1273

Verification Steps

  1. Simulate Slow 3G in network tab and navigate to /search.html?query=top
  2. Observe new placeholder where search icon used to be misaligned

How have YOU tested this?

Ran yarn test and manually checked above steps

Screenshots / Screen Captures (if appropriate):

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 13, 2019
@vercel
Copy link

vercel bot commented Jun 13, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-feature-search-suspense-component.magento-research1.now.sh

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 13, 2019

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against fc4619b

sirugh
sirugh previously approved these changes Jun 18, 2019
@dpatil-magento
Copy link
Contributor

QA Pass. @sirugh If new changes are good, please go ahead and merge this one.

Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request before we merge.


.input {
composes: input from '../TextInput/textInput.css';
max-width: 24rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value comes from searchBar.css as we want the placeholder to look identical to the searchBar once it loads. I think this should be a constant somewhere shared between both css files so we only have to update in one place in the future.

}

.loader:before {
color: rgb(var(--venia-grey));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to nitpick but on my screen this is super light and really difficult to see. If this value is from the mocks, fine, but maybe it needs to be darker.

@sirugh sirugh merged commit b3638f8 into develop Jun 20, 2019
@sirugh sirugh deleted the feature/search-suspense-component branch July 25, 2019 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: [RE-Opened ] - Second search icon breaks header bar during load
4 participants