[dev]: Update feather to 2.0.x #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-updatefeather.magento-research1.now.sh |
sirugh
commented
Jul 8, 2019
| import WifiIcon from 'react-feather/dist/icons/wifi'; | ||
| import { AlertCircle as AlertCircleIcon } from 'react-feather'; | ||
| import { CloudOff as CloudOffIcon } from 'react-feather'; | ||
| import { Wifi as WifiIcon } from 'react-feather'; |
There was a problem hiding this comment.
I could now combine these into a single import with csv -- just kept them individual for diff sake.
There was a problem hiding this comment.
I can do that -- the truth is I used a regex replace for these to make the initial conversion :D
|
sirugh
added
the
version: Patch
jimbo
approved these changes
Jul 15, 2019
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates feathericons to 2.0.3 and uses named imports instead of specifying path.
Related Issue
Closes #1415 .
Verification Steps
venia-conceptrunyarn build:analyzebefore and after this PR. Compare size. After this PR we should gain less than a KB in size (probably due to updates in the feather repo).Screenshots / Screen Captures (if appropriate)
Before
After
Proposed Labels for Change Type/Package
Checklist: