[docs] Revise configuration management draft #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
the
version: Minor
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-jimothy-gh-1420update-config-docs.magento-research1.now.sh |
|
sirugh
reviewed
Jul 19, 2019
|
|
||
| // Use the convenience properties `isProd` and `isDev` instead of testing | ||
| // `process.env.NODE_ENV` directly: | ||
| if (configuration.isDev) { |
There was a problem hiding this comment.
Above we reference isDevelopment and isProduction but here you mention the shorthand. Which is correct?
There was a problem hiding this comment.
They are both correct. If you look at the reference table, the shorthand versions are under the Alias column.
sirugh
approved these changes
Jul 22, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR breaks up the original configuration management draft topic into separate, smaller topics.
They are still in the
_draftsfolder because the tool is not yet released.Related Issue
Closes #1420
Verification Steps
No verification is needed since everything is still in a draft state.
Checklist: