Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[doc] Update modular components docs #1439

Merged
merged 2 commits into from
Jul 22, 2019
Merged

[doc] Update modular components docs #1439

merged 2 commits into from
Jul 22, 2019

Conversation

jcalcaben
Copy link
Contributor

Description

Update modular component docs to remove mention of using NPM instead of Yarn.
Linting issues for that topic has also been fixed in this PR.

Related Issue

Closes #907

Verification Steps

  1. Navigate to the pwa-devdocs directory
  2. Run linting: npm run lint src/venia-pwa-concept/features/modular-components/index.md
  3. Verify no linting issues found for that topic.

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jul 15, 2019
@vercel
Copy link

vercel bot commented Jul 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-jimothy-gh-907update-modular-components-docs.magento-research1.now.sh

@jcalcaben jcalcaben added docs documentation documentation This pertains to documentation. labels Jul 15, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jul 15, 2019 •
edited
Loading

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against f8810e5

cherdman
cherdman approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@cherdman cherdman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@dpatil-magento dpatil-magento merged commit 70700cf into develop Jul 22, 2019
@jcalcaben jcalcaben deleted the jimothy/gh-907_update-modular-components-docs branch July 25, 2019 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sirugh sirugh sirugh approved these changes

@cherdman cherdman cherdman approved these changes

Assignees
No one assigned
Labels
docs documentation documentation This pertains to documentation. version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs]: Remove NPM from Modular install docs and promote Yarn
5 participants
@jcalcaben @PWAStudioBot @sirugh @cherdman @dpatil-magento