Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Google Tag manager for analytics #1450

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

belbiy
Copy link
Contributor

@belbiy belbiy commented Jul 18, 2019

Description

This PR changes the way we track users with Google Analytics on the PWA docs site. It adds the Google Tag manager script to deliver the tracking and the Hotjar code.

Same Google Tag manager container is used as we use on devdocs.magento.com

@vercel
Copy link

vercel bot commented Jul 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-fork-belbiy-ybtag-manager.magento-research1.now.sh

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jul 18, 2019

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 0a390b6

@jcalcaben jcalcaben self-assigned this Jul 18, 2019
@jcalcaben jcalcaben added pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes. labels Jul 18, 2019
@jcalcaben jcalcaben removed their assignment Jul 18, 2019
@jcalcaben
Copy link
Contributor

@dpatil-magento I don't think there's anything here to QA. There is a dangerfile error but I don't think its related to this PR.

@dpatil-magento
Copy link
Contributor

@jcalcaben After latest develop merge error gone. Current errors are related to missing details. Regression scripts pass.

@dpatil-magento dpatil-magento merged commit bf5a040 into magento:develop Jul 19, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants