Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates js-yaml dependency to 3.13.1 #1464

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

supernova-at
Copy link
Contributor

Description

Our upward-js and upward-spec packages have a dependency on js-yaml.

Our dependency was on version 3.12.1, which caused two security alerts.

The fix was to update to version 3.13.1.

According to js-yaml's changelog, there were no code changes needed. We use safeLoad instead of load in upward-spec and upward-js.

Related Issue

Closes #1298 .

Verification Steps

  1. yarn clean:all
  2. yarn install
  3. yarn test

See that install and test succeed.

Screenshots / Screen Captures (if appropriate)

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented Jul 25, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-supernova-1298updatejsyaml.magento-research1.now.sh

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Jul 25, 2019
@PWAStudioBot PWAStudioBot added pkg:upward-js Pertains to upward-js reference implementation of UPWARD. pkg:upward-spec Pertains to UPWARD specification package. labels Jul 25, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jul 25, 2019

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against 0e88dce

@sirugh
Copy link
Contributor

sirugh commented Jul 25, 2019

Want to just fix webpack bundle analyzer vuln as well?

@supernova-at
Copy link
Contributor Author

Want to just fix webpack bundle analyzer vuln as well?

I ended up creating #1466 for that 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:upward-js Pertains to upward-js reference implementation of UPWARD. pkg:upward-spec Pertains to UPWARD specification package. version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository Security Alert: js-yaml
4 participants