Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[doc] Restore banner's original content #1506

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

jcalcaben
Copy link
Contributor

Description

This PR will remove the migration message and restore the message to the previous one.

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

  1. Navigate to the pwa-devdocs directory
  2. Build the preview HTML: npm run develop
  3. Verify the blue banner is back with original message.

Screenshots / Screen Captures (if appropriate)

n/a

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Minor This changeset includes functionality added in a backwards compatible manner. docs documentation labels Aug 1, 2019
@vercel
Copy link

vercel bot commented Aug 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-jimothy-restorebanner.magento-research1.now.sh

@jcalcaben jcalcaben changed the title Restore banner's original content [doc] Restore banner's original content Aug 1, 2019
@PWAStudioBot
Copy link
Contributor

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against 1d3cdd9

@supernova-at supernova-at self-assigned this Aug 1, 2019
@supernova-at supernova-at added the hold On hold until another condition is fulfilled. label Aug 1, 2019
@supernova-at
Copy link
Contributor

Added the hold label because this should not be merged until after the repository is moved.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs documentation documentation This pertains to documentation. hold On hold until another condition is fulfilled. pkg:pwa-devdocs version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants