Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Removes version checklist from pr template #1567

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Removes version checklist from pr template #1567

merged 3 commits into from
Aug 15, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Aug 15, 2019 •
edited
Loading

Description

Removes the checklists from pr template

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

  1. Ensure danger is not complaining about a missing version section IN the PR. It'll still complain if the label is missing.

Screenshots / Screen Captures (if appropriate)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@sirugh sirugh added tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. version: Patch This changeset includes backwards compatible bug fixes. labels Aug 15, 2019
@vercel
Copy link

vercel bot commented Aug 15, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://pwa-studio-git-sirugh-removecheckboxtemplate.mmansoor.now.sh

@sirugh sirugh requested a review from supernova-at August 15, 2019 16:40
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 15, 2019 •
edited
Loading

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.
🚫 A version label is required. A maintainer must add one.
Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against 97882ea

@dpatil-magento dpatil-magento removed the version: Patch This changeset includes backwards compatible bug fixes. label Aug 15, 2019
@dpatil-magento dpatil-magento added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 15, 2019
@dpatil-magento dpatil-magento merged commit 65fe809 into develop Aug 15, 2019
@dpatil-magento dpatil-magento deleted the sirugh/remove_checkbox_template branch August 15, 2019 17:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jcalcaben jcalcaben jcalcaben approved these changes

@supernova-at supernova-at Awaiting requested review from supernova-at

Assignees

@jcalcaben jcalcaben

Labels
tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirugh @PWAStudioBot @jcalcaben @dpatil-magento