Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removes Now.sh pipeline #1575

Merged
merged 14 commits into from
Sep 6, 2019
Merged

Removes Now.sh pipeline #1575

merged 14 commits into from
Sep 6, 2019

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Aug 16, 2019

Description

We have AWS deploying on a per-PR basis, so we no longer need the Now.sh pipeline. Our https://veniapwa.com demo site has been redirected to the AWS deployment of master.

Related Issue

Closes #1546.

Verification Steps

  1. Verify that now.sh-related code doesn't appear anywhere in the codebase
  2. Verify that the Now GitHub integration no longer appears on PRs

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.
  • Remove the Magento team from Now.sh website
  • @mmansoor-magento to remove Now GitHub App from magento organization

@vercel
Copy link

vercel bot commented Aug 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://pwa-studio-git-supernova-1546retirenow.magento.now.sh

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 16, 2019

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 56f8143

@supernova-at supernova-at requested a review from zetlen August 16, 2019 20:22
@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 16, 2019
@dpatil-magento dpatil-magento added the pwa-4.0.0 To track PWA 4.0.0 tickets label Aug 19, 2019
@dpatil-magento
Copy link
Contributor

veniapwa.com equivalent AWS magento.pwa-venia.com
magento-venia-develop.now.sh equivalent AWS develop.pwa-venia.com

Copy link
Contributor Author

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had an offline conversation with @zetlen about not removing Now completely because it does still provide some value because it runs in a lambda and it will keep us honest about the application not being stateful.

We have therefore repurposed this ticket to update our Now installation.

@supernova-at supernova-at changed the title Removes all references to now.sh Updates to now.sh Aug 23, 2019
@supernova-at
Copy link
Contributor Author

supernova-at commented Sep 3, 2019

#1595 is in! This issue is unblocked and has been updated.

Good news and bad news though:

Good News:

The deployments are working. If you hit https://pwa-studio.supernova-at.now.sh/ you do see Venia.

Bad News:

Screen Shot 2019-09-03 at 2 21 08 PM

The app is repeatedly attempting to hit /rest/V1/guest-carts at the deployment URL (ex: https://pwa-studio.supernova-at.now.sh/rest/V1/guest-carts), not the MAGENTO_BACKEND_URL.

We have followed the documentation to provide environment variables at both build and run time via our now.json file.

I'm stuck 😢

@zetlen
Copy link
Contributor

zetlen commented Sep 4, 2019

That should work though. UPWARD ought to properly proxy that request to MAGENTO_BACKEND_URL. But you can also reproduce that proxying behavior before it hits upward-js. I think you might need to add the routes section of now.json back. Without that, I'm not sure how we're making every single request resolve to index.html!

@cherdman cherdman removed the hold On hold until another condition is fulfilled. label Sep 4, 2019
@vercel vercel bot temporarily deployed to staging September 5, 2019 16:30 Inactive
@supernova-at supernova-at changed the title [WIP] Updates to now.sh Removes Now.sh pipeline Sep 5, 2019
@supernova-at
Copy link
Contributor Author

Update: following a team meeting this PR has been repurposed back to removing Now.sh entirely.

If / when we want a deployment target other than the Magento Cloud we can add it back.

@supernova-at supernova-at removed their assignment Sep 5, 2019
@dpatil-magento dpatil-magento merged commit baf065e into develop Sep 6, 2019
@dpatil-magento dpatil-magento deleted the supernova/1546_retire_now branch September 6, 2019 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CICD] - Retire now.sh for pwa-studio
6 participants