-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Removes Now.sh pipeline #1575
Removes Now.sh pipeline #1575
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://pwa-studio-git-supernova-1546retirenow.magento.now.sh |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had an offline conversation with @zetlen about not removing Now completely because it does still provide some value because it runs in a lambda and it will keep us honest about the application not being stateful.
We have therefore repurposed this ticket to update our Now installation.
#1595 is in! This issue is unblocked and has been updated. Good news and bad news though: Good News: The deployments are working. If you hit https://pwa-studio.supernova-at.now.sh/ you do see Venia. Bad News: The app is repeatedly attempting to hit We have followed the documentation to provide environment variables at both build and run time via our I'm stuck 😢 |
That should work though. UPWARD ought to properly proxy that request to MAGENTO_BACKEND_URL. But you can also reproduce that proxying behavior before it hits upward-js. I think you might need to add the |
Update: following a team meeting this PR has been repurposed back to removing Now.sh entirely. If / when we want a deployment target other than the Magento Cloud we can add it back. |
Description
We have AWS deploying on a per-PR basis, so we no longer need the Now.sh pipeline. Our https://veniapwa.com demo site has been redirected to the AWS deployment of
master
.Related Issue
Closes #1546.
Verification Steps
now.sh
-related code doesn't appear anywhere in the codebaseNow
GitHub integration no longer appears on PRsScreenshots / Screen Captures (if appropriate)
Checklist
Magento
team fromNow.sh
websiteNow
GitHub App frommagento
organization