Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use eval-source-map instead of cheap-source-map for devtool #1581

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Use eval-source-map instead of cheap-source-map for devtool #1581

merged 1 commit into from
Aug 20, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Aug 20, 2019 •
edited
Loading

Description

Switches us to eval-source-map.

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

  1. yarn watch:all and inspect some source code like minicart.js it should be non-transpiled and have comments

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@sirugh sirugh added the tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. label Aug 20, 2019
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 20, 2019
@PWAStudioBot
Copy link
Contributor

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 3e6d0fc

@dpatil-magento dpatil-magento merged commit fb3664b into develop Aug 20, 2019
@dpatil-magento dpatil-magento deleted the sirugh/eval-source-map branch August 20, 2019 19:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@jimbo jimbo

Labels
pkg:pwa-buildpack tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirugh @PWAStudioBot @jimbo @dpatil-magento