Changed prop type of uniqueID for Item component. #1586
Conversation
revanth0212
added
the
version: Minor
| @@ -54,7 +54,8 @@ Item.propTypes = { | |||
| item: PropTypes.any.isRequired, | |||
| itemIndex: PropTypes.number.isRequired, | |||
| render: PropTypes.oneOfType([PropTypes.func, PropTypes.string]).isRequired, | |||
| uniqueID: PropTypes.number | |||
| uniqueID: PropTypes.oneOfType([PropTypes.number, PropTypes.string]) | |||
There was a problem hiding this comment.
Are the uses of uniqueID within this component capable of handling either?
There was a problem hiding this comment.
I think this uses a set downstream which means we need to make sure to use a single type.
There was a problem hiding this comment.
Yes, we just use it as key for a component. Since react does not allow users to send a prop called key to its children, I am just passing it down as uniqueID. Once it reaches the Item component, it is used as key which can be number or string.
|
|
Thanks for fixing this :) |
Description
uniqueID prop check was failing since it was mentioned that uniqueID will be a number but in case of
categorycomponent which internally usesitem, it can be a string as well.So no more errors like this:
Related Issue
None. No issue for this. It is just a dev fix.
Closes nothing.
Verification Steps
No more console errors related to prop types.
Checklist
Check the console for prop types errors in category and product pages.