-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix test config #1606
fix test config #1606
Conversation
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
It seems to be working for me on
Result:
|
Well... that's weird. It's working for me too. I don't know how to repro! |
Man, I'm still not getting the error on Your console output includes "Determining test suites to run..." but mine never does 🤔 |
Happened to me till yesterday when I tried to use jest in watch mode. Unfortunately, I am not able to reproduce it now. Weird. |
Checked out the repo anew and ran |
Verification steps complete ✅ |
Description
OK here's why it's broken.
jest.config.js
usesinPackage
to create a path to things in configs. It's a fancy helper for resolving paths. The specific problem is that__mocks__/fileMock.js
does not exist invenia-concept
. I think that jest caches some things after running which is why you may or may not see this issue but I assure you it is a problem. If you do a clean checkout into a new directory you should see it happen.So, we can solve this one of two ways.
Any test config using
testVenia
hardcodes a path to__mocks__/fileMock.js
invenia-ui
.Create the
__mocks__/fileMock.js
invenia-concept
.Personally I don't care what we chose but it is broken and we should fix it.
Verification
yarn test:dev
/jest --watch
doesn't break.