Create authBar and userChip talons #1751
Conversation
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
sirugh
added
the
version: Patch
supernova-at
changed the title
| * @param {function} props.showMyAccount - callback that displays my account view | ||
| * @param {function} props.showSignIn - callback that displays # view | ||
|
|
||
| * @return {{ currentUser: object, handleClick: function, isSignedIn: boolean, isSignInDisabled: boolean, showMyAccount: function }} |
There was a problem hiding this comment.
This comment doesn't match what's returned from the function
There was a problem hiding this comment.
Also this is a bit hard to read. Would be extra 🥇 if these were broken out and described like props is above, though I'm cool with improving that later.
| ) : ( | ||
| <Button disabled={!!disabled} priority="high" onClick={handleClick}> |
There was a problem hiding this comment.
Looks like we lost the !! for this button being disabled. Will the disabled prop ever not be a boolean?
There was a problem hiding this comment.
Looks like it will always be a boolean 👍
Navigation is the only place that calls AuthBar:
const hasModal = view !== 'MENU';
// ...
<AuthBar
disabled={hasModal}
showMyAccount={showMyAccount}
showSignIn={showSignIn}
/>
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
No description provided.