Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[doc] state management #1785

Merged
merged 11 commits into from
Sep 27, 2019
Merged

[doc] state management #1785

merged 11 commits into from
Sep 27, 2019

Conversation

jcalcaben
Copy link
Contributor

@jcalcaben jcalcaben commented Sep 25, 2019 •
edited
Loading

Description

Create topic about state management in PWA Studio

Related Issue

Closes #1720

Acceptance

Verification Stakeholders

Verification Steps

  1. Navigate to pwa-devdocs directory
  2. Run linter on the new topic: npm run lint src/technologies/basic-concepts/state-management/index.md
  3. Verify no linting errors.
  4. Start the HTML preview server: npm run develop
  5. Navigate to /technologies/basic-concepts/state-management/
  6. Verify page exists and it is highlighted in table of contents

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Sep 25, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 25, 2019 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against ca44ea4

@sirugh sirugh self-assigned this Sep 25, 2019
sirugh
sirugh reviewed Sep 26, 2019
View reviewed changes
pwa-devdocs/_drafts/state-management/index.md Outdated
const apiBase = new URL('/graphql', location.origin).toString();

ReactDOM.render(
<Adapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the Adapter in this example?

sirugh
sirugh reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few comments but nothing necessarily holding this up. Great documentation!

@cherdman cherdman self-requested a review September 26, 2019 15:53
cherdman
cherdman previously approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@cherdman cherdman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@jcalcaben @sirugh
Update pwa-devdocs/src/technologies/basic-concepts/state-management/i…
2a8129d 
…ndex.md

Co-Authored-By: Stephen Rugh <sirugh@users.noreply.github.com>
@dpatil-magento dpatil-magento merged commit 9935bf7 into develop Sep 27, 2019
@dpatil-magento dpatil-magento deleted the jimothy/gh-1720_state-management branch September 27, 2019 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sirugh sirugh sirugh approved these changes

@cherdman cherdman cherdman approved these changes

Assignees

@sirugh sirugh

@cherdman cherdman

Labels
version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc]: State management
5 participants
@jcalcaben @PWAStudioBot @sirugh @cherdman @dpatil-magento