Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Pagination talon #1812

Merged
merged 7 commits into from
Oct 1, 2019
Merged

Pagination talon #1812

merged 7 commits into from
Oct 1, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Sep 30, 2019

Had to refactor Pagination to a function component. Be warned!

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 30, 2019 •
edited
Loading

Fails
🚫 Missing "Description" section. Please add it back, with detail.
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against cdf2933

jimbo
jimbo previously approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a few quick suggestions related to the original code; merge them in if you like.

@sirugh @jimbo
Update packages/peregrine/lib/talons/Pagination/usePagination.js
e2f2c49 
Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
sirugh and others added 3 commits October 1, 2019 11:54
@sirugh @jimbo
Update packages/peregrine/lib/talons/Pagination/usePagination.js
183ea70 
Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
@sirugh @jimbo
Update packages/venia-ui/lib/components/Pagination/pagination.js
33acfc6 
Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
@jimbo
Merge branch 'develop' into rugh/talon-pagination
4c07037
@dpatil-magento dpatil-magento merged commit 00354a0 into develop Oct 1, 2019
@dpatil-magento dpatil-magento deleted the rugh/talon-pagination branch October 1, 2019 18:59
@jimbo jimbo mentioned this pull request Oct 2, 2019
Closed
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@jimbo jimbo

Labels
pkg:peregrine pkg:venia-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirugh @PWAStudioBot @jimbo @dpatil-magento