Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove duplicate code #1838

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Remove duplicate code #1838

merged 2 commits into from
Oct 4, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Oct 3, 2019 •
edited
Loading

Description

This PR removes some duplicate code.

Related Issue

Closes #<issue_number>

Acceptance

Verification Stakeholders

Specification

Verification Steps

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 3, 2019 •
edited
Loading

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against f5f5ba3

sirugh
sirugh reviewed Oct 4, 2019
View reviewed changes
packages/venia-ui/lib/components/Checkout/paymentsFormItems.js
@@ -38,7 +38,6 @@ const PaymentsFormItems = props => {
setIsReady
} = usePaymentsFormItems({
isSubmitting,
onCancel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 4, 2019
@dpatil-magento dpatil-magento merged commit a5cb21b into magento:develop Oct 4, 2019
@DanielRuf DanielRuf deleted the fix/remove-duplicate-code branch October 4, 2019 16:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

Labels
pkg:pwa-buildpack pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielRuf @PWAStudioBot @sirugh @dpatil-magento