Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent that the animation-fill-mode is overwritten #1839

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Prevent that the animation-fill-mode is overwritten #1839

merged 2 commits into from
Oct 4, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Oct 3, 2019

Description

The shorthand animation overwrites the longhand animation-fill-mode. Switching the line prevents this. The value would be animation-fill-mode: none.

Also see https://codepen.io/DanielRuf/pen/YzzKeKm

Related Issue

Closes #<issue_number>

Acceptance

Verification Stakeholders

Specification

Verification Steps

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 3, 2019

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 01c89e8

Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find - thanks!

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 4, 2019
@dpatil-magento dpatil-magento merged commit d5c9f6c into magento:develop Oct 4, 2019
@DanielRuf DanielRuf deleted the fix/prevent-animation-fill-mode-overwritten branch October 4, 2019 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants