Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: npx bundlesize path resolution issue #1854

Merged
merged 2 commits into from
Oct 7, 2019
Merged

fix: npx bundlesize path resolution issue #1854

merged 2 commits into from
Oct 7, 2019

Conversation

distributedlock
Copy link
Contributor

@distributedlock distributedlock commented Oct 6, 2019 •
edited
Loading

No description provided.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 6, 2019 •
edited
Loading

Fails
🚫 Issue 1542 is closed. Please make sure the linked issue is correct and open.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against a1a0007

@distributedlock
fix: bundlesize path resolution issue
8eb6af3 
Resolves #1542.

Signed-off-by: Ranadeep Polavarapu <ranadeep@icloud.com>
@distributedlock distributedlock changed the title Fix/1542 fix: bundlesize path resolution issue Oct 6, 2019
@distributedlock distributedlock changed the title fix: bundlesize path resolution issue fix: npx bundlesize path resolution issue Oct 6, 2019
@supernova-at supernova-at self-assigned this Oct 7, 2019
supernova-at
supernova-at approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you!

It also allows us to get a little more granular with the maxSizes we set, which I'll create a separate issue for. Thanks again!

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 7, 2019
@dpatil-magento dpatil-magento merged commit adfa033 into magento:develop Oct 7, 2019
@distributedlock distributedlock mentioned this pull request Nov 19, 2019
Closed
41 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

Assignees

@supernova-at supernova-at

Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@distributedlock @PWAStudioBot @supernova-at @dpatil-magento