Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[docs] peregrine talons overview #1876

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

jcalcaben
Copy link
Contributor

Description

Creates an unpublished doc topic about Peregrine talon. It is unpublished because talons are not currently available in 4.0.0.

Related Issue

Closes #1756

Acceptance

@jimbo
@sirugh

Verification Stakeholders

@jimbo
@sirugh

Verification Steps

  1. Navigate to the pwa-devdocs directory: cd pwa-devdocs
  2. Run the linter on the new file: npm run lint _drafts/talons/index.md
  3. Verify no linting errors.

This topic is not published so there is no need to do an HTML preview.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Oct 9, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 9, 2019

Fails
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 8c1bc4f

Peregrine **talons** are designed to fulfill the logic needs of a single Venia UI component.
This means that each talon belongs to a specific UI component in Venia and is not used in any other Venia component.

For example, the functionality provided by the `useHeader()` talon is only relevant to the the `Header` component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To expand on this section:

Going forward we may identify pieces of talons that perform identical functionality and that can be moved to a hook. We're being extra careful not to do that just yet because we don't want to create more API surface that we have to support (since this is so new) but we may do this in the future.

Take that as you will -- not sure if it's worth adding anything in here about that.


Venia UI components use talons by default, so
developers can use Venia UI components as is without worrying about talons.
If developers want to change how a Venia UI component looks, they can import its associated talon into a new or modified UI component of the same type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension/customization story isn't quite complete but maybe we want to show an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather wait until the story is complete before adding more information about it

sirugh
sirugh previously approved these changes Oct 10, 2019
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overview, let's get this published.

@jcalcaben jcalcaben requested a review from jimbo October 11, 2019 16:21
@dpatil-magento dpatil-magento self-requested a review October 11, 2019 16:34
@dpatil-magento dpatil-magento merged commit ccf014f into develop Oct 11, 2019
@dpatil-magento dpatil-magento deleted the jimothy/gh-1756_talons-overview branch October 11, 2019 16:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc]: Talons documentation
5 participants