Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#1915: remove redux.compose() where not needed #1916

Merged
merged 3 commits into from
Oct 22, 2019
Merged

#1915: remove redux.compose() where not needed #1916

merged 3 commits into from
Oct 22, 2019

Conversation

brendanfalkowski
Copy link
Contributor

Description

Removes redux.compose() where it's not being used to compose multiple functions.

Related Issue

Closes #1915

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Should pass build.

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 19, 2019 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 7ea59cf

@supernova-at supernova-at self-assigned this Oct 22, 2019
@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 22, 2019
supernova-at
supernova-at approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@dpatil-magento dpatil-magento merged commit a1e199b into magento:develop Oct 22, 2019
@brendanfalkowski brendanfalkowski deleted the 1915-remove-redux-compose-where-not-needed branch October 22, 2019 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

Assignees

@supernova-at supernova-at

Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: remove redux.compose() where not needed
4 participants
@brendanfalkowski @PWAStudioBot @supernova-at @dpatil-magento