Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can ignore the description -- I was going to make some changes to the dependencies for upward-spec but decided against that. So this is just some docs changes to fix some issues I ran in when running the steps in the upward-spec readme.
Description
This PR is really in regards to the security issues reported on the upward-php repo.
That said, there is little we can actually do aside from not using
tap-diff
as the repo hasn't been updated in 4 years. Since we're indirectly usingdiff
throughtap-diff
which is simply a test reporter (used when you run theupward-spec
bin) I think we can resolve this security report as a won't fix. However, if people feel strongly enough we could remove thetap-diff
dependency and output entirely. There are a lot of other options for tap output prettifiers but most are really outdated.So the only change I made here was a fix to the
npx
command in the readme that wasn't working and to make the test script executable by default so that you can actually run the command.Related Issue
Doesn't quite close PWA-126. For that we will need to do the steps listed in that ticket.
Verification steps