Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: default to valid initialValue for checkout form #1983

Merged
merged 11 commits into from
Dec 3, 2019

Conversation

dani97
Copy link
Contributor

@dani97 dani97 commented Nov 18, 2019

Description

Fixes #1460

Related Issue

Closes #1460

Acceptance

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

Go to Venia and add a product to cart.
Click on checkout button.
Click on "Ship To" link. (Shipping address input form displayed)
Click anywhere in the page to close right drawer. (Just Dont Close right drawer by clicking X icon).
# to account via main menu.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Nov 18, 2019

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 22567e8

dani97 and others added 2 commits November 23, 2019 11:54
Co-Authored-By: Revanth Kumar Annavarapu <35203638+revanth0212@users.noreply.github.com>
@dani97
Copy link
Contributor Author

dani97 commented Nov 23, 2019

@sirugh on the exact situation reported by @dpatil-magento , null was sent as initialValue to the componenet.

@dani97 dani97 requested review from sirugh and revanth0212 November 23, 2019 19:14
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 27, 2019
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does fix the specific issue for the case of the address form it does not for other forms such as payment which you can reproduce by following the repro steps but instead of address form click payment form (and uncheck billing address is same as shipping).

Image from Gyazo

Please apply the same fix to the paymentsForm component :)

@dani97
Copy link
Contributor Author

dani97 commented Nov 28, 2019

While this does fix the specific issue for the case of the address form it does not for other forms such as payment which you can reproduce by following the repro steps but instead of address form click payment form (and uncheck billing address is same as shipping).

Image from Gyazo

Please apply the same fix to the paymentsForm component :)

Fixed it 👍

@sirugh sirugh changed the title fix type error [bug]: default to valid initialValue for checkout form Dec 3, 2019
@supernova-at supernova-at merged commit 67bc7c9 into magento:develop Dec 3, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
6 participants