[chore] Update eslint dep #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirugh
added
the
version: Patch
sirugh
added
the
tooling
PWAStudioBot
added
pkg:peregrine
pkg:pwa-buildpack
pkg:upward-js
|
revanth0212
previously approved these changes
Nov 22, 2019
jimbo
suggested changes
Nov 26, 2019
| rules: { | ||
| 'no-undef': 'off', | ||
| 'no-useless-escape': 'off' | ||
| } |
There was a problem hiding this comment.
Why do we have to define these two rules everywhere?
There was a problem hiding this comment.
Because we disregard them throughout the application. The alternative would be to add these rules to magento-eslint.
There was a problem hiding this comment.
I added these to magento-eslint and published but I'm reconsidering that... I don't think we should be disabling no-undef. We should be updating some config with those values somewhere.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
jimbo
suggested changes
Nov 26, 2019
packages/upward-js/lib/resolvers/__tests__/TemplateResolver.test.js
Outdated
Show resolved
Hide resolved
jimbo
previously approved these changes
Nov 26, 2019
sirugh
force-pushed
the
update-eslint-dep
branch
from
005ec01 to
2a77128
Compare
jimbo
previously approved these changes
Dec 3, 2019
zetlen
previously approved these changes
Dec 3, 2019
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
tjwiebell
approved these changes
Dec 4, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to the
magento-eslintsecurity issue. I updated our usage tov1.5.0and in doing so had to handle a bunch of new warnings/errors. I also had to update some peer dependencies and install the config as a dependency to buildpack and peregrine where it was not before.Question: Should this be a patch? People using it with custom components may start getting warnings for things.
Related Issue
Closes PWA-193.
Acceptance
Verification Stakeholders
@jimbo @zetlen
Specification
Verification Steps
yarn && yarn lint, no errors.Screenshots / Screen Captures (if appropriate)
Checklist