Add typography section to styleguide #2013
Conversation
jimbo
added
in progress
version: Minor
|
| </Columns> | ||
| <Columns reverse={true}> | ||
| <Emphasis /> | ||
| </Columns> |
There was a problem hiding this comment.
This looks weird -- should the text be contained within the grey-box background?
| <Section title="Formatting"> | ||
| <Formatting /> | ||
| </Section> | ||
| <Section title="Usage guidelines" /> |
There was a problem hiding this comment.
This is empty. Drop some lorem text placeholder?
| *** | ||
|
|
||
| <Columns> | ||
| <FontSize /> |
There was a problem hiding this comment.
Maybe it's the columns component but it looks like it makes two columns differing by background.
| @@ -0,0 +1,4 @@ | |||
| .title { | |||
| font-size: var(--venia-global-text-fontSize-1100); | |||
There was a problem hiding this comment.
This feels like it should use a typography token for heading but I didn't find one that used 1100.
| export const H3 = props => <Heading {...props} level={3} />; | ||
| export const H4 = props => <Heading {...props} level={4} />; | ||
| export const H5 = props => <Heading {...props} level={5} />; | ||
| export const H6 = props => <Heading {...props} level={6} />; |
There was a problem hiding this comment.
These don't seem to be used anywhere. Are these supposed to be components for the styleguide UI or for use in PWA Studio (why not both?)
There was a problem hiding this comment.
Oh nvm I see the MDXAdapter :)
|
Verification steps looks good. Need @jcalcaben @soumya-ashok approval to merge this one. |
Description
Add a typography section to the styleguide. The prose content may be lorem ipsum, but the values should reflect the the official Venia styles.
Related Issue
PWA-153
Acceptance
Verification Stakeholders
@jcalcaben @soumya-ashok
Specification
Verification Steps
yarn workspace @magento/venia-styleguide run start/page/typographyScreenshots / Screen Captures (if appropriate)
Checklist