Refactor checkout workflow to set shipping address/get shipping methods with graphql #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sirugh
force-pushed
the
rugh/getShippingMethods-graphql
branch
2 times, most recently
from
bdf3137 to
4030d43
Compare
sirugh
added
the
version: Major
…ng methods in single action.
sirugh
force-pushed
the
rugh/getShippingMethods-graphql
branch
from
4030d43 to
e89c9be
Compare
supernova-at
requested changes
Dec 16, 2019
packages/venia-ui/lib/components/Checkout/__tests__/__snapshots__/addressForm.spec.js.snap
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/Checkout/shippingAddressSummary.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/Checkout/shippingMethodSummary.js
Outdated
Show resolved
Hide resolved
|
|
||
| const [ | ||
| { shippingAddress, shippingMethod, shippingTitle } | ||
| ] = useCheckoutContext(); |
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
supernova-at
previously approved these changes
Dec 16, 2019
|
QA pass but waiting for #2029 to get merged first. |
dpatil-magento
approved these changes
Dec 18, 2019
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses graphQL to set shipping address and, in the same mutation, receive the available shipping methods for the selected address.
Also removes email from forms for authed users as the email is already attached to cart.
For guest users it will set the guest email on the cart when submitting the address form.
Related Issue
Closes PWA-145.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist