Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search Result Counts Match #2037

Merged
merged 13 commits into from
Jan 3, 2020
Merged

Search Result Counts Match #2037

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ec46c04
Fixes search page results count bug
supernova-at Dec 18, 2019
e2f1ac7
Merge branch 'develop' into supernova/97_search_result_count
supernova-at Dec 18, 2019
632804e
Merge branch 'develop' into supernova/97_search_result_count
supernova-at Dec 18, 2019
6dcf63b
Adds pagination to search page
supernova-at Dec 18, 2019
135c766
Updates autocomplete unit test
supernova-at Dec 18, 2019
95ab17b
Updates autocomplete unit test
supernova-at Dec 18, 2019
da3ff7b
Code styling
supernova-at Dec 18, 2019
0ca78de
Merge branch 'develop' into supernova/97_search_result_count
dpatil-magento Dec 19, 2019
c6af1ce
Fixes search pagination bugs
supernova-at Dec 19, 2019
fd01eaa
Merge branch 'supernova/97_search_result_count' of github.com:magento…
supernova-at Dec 19, 2019
19d17c6
Reset back to page one on category change
supernova-at Dec 20, 2019
c8bb19c
Merge branch 'develop' into supernova/97_search_result_count
dpatil-magento Dec 20, 2019
71aa5d2
Merge branch 'develop' into supernova/97_search_result_count
tjwiebell Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/venia-ui/lib/components/SearchPage/searchPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const SearchPage = props => {
}

const { products } = data;
const { filters, total_count, items } = products;
const { filters, items } = products;

if (items.length === 0) {
return <div className={classes.noResult}>No results found!</div>;
Expand All @@ -61,9 +61,9 @@ const SearchPage = props => {
return (
<article className={classes.root}>
<div className={classes.categoryTop}>
<div className={classes.totalPages}>
{`${total_count} items`}
</div>
<div className={classes.totalPages}>{`${
items.length
} items`}</div>
{maybeCategoryFilters}
{maybeFilterButtons}
</div>
Expand Down