Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bugfix] After adding product to cart toggle the cart drawer #2038

Merged
merged 4 commits into from
Dec 19, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Dec 18, 2019

Description

When we moved updateItem to gql we, for configurable items, used the remove/add actions internally.

The add action used to invoke toggleDrawer('cart'), which no longer makes sense in this sense.

So instead of toggling within the action we now toggle in the UI where we should, after the action resolves.

Related Issue

Closes PWA-253.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Add a configurable item to the cart. It should toggle the cart.
  2. Add a simple item to the cart. It should toggle the cart.
  3. Update the configurable item. It should not close the cart after it is updated.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@sirugh sirugh changed the title After adding product to cart toggle the cart drawer [bugfix] After adding product to cart toggle the cart drawer Dec 18, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Dec 18, 2019

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-253.

Generated by 🚫 dangerJS against 86b8595

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Dec 18, 2019
Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find, good fix 👍

@sirugh sirugh changed the base branch from develop to release/5.0 December 19, 2019 15:21
@sirugh sirugh changed the base branch from release/5.0 to develop December 19, 2019 15:22
@dpatil-magento dpatil-magento merged commit ad37c12 into develop Dec 19, 2019
@dpatil-magento dpatil-magento deleted the rugh/bugfix/togglecart branch December 19, 2019 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants