Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[feature] intermediate breadcrumbs #2113

Merged
merged 6 commits into from
Jan 30, 2020
Merged

[feature] intermediate breadcrumbs #2113

merged 6 commits into from
Jan 30, 2020

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Jan 23, 2020

Description

In 2.3.3 we were not able to retrieve the path for intermediate level breadcrumbs. 2.3.4 allows this.

Related Issue

Closes PWA-161.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to a product page and click an intermediate breadcrumb (not Home or the last category. it should link to the right category.
  2. Regress breadcrumbs and make sure nothing is broken.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

sirugh added 2 commits January 23, 2020 14:05
@sirugh
Enable intermediate level breadcrumbs using category_url_path
ad5706f 
Signed-off-by: Stephen Rugh <rugh@adobe.com>
@sirugh
fix tests
dbd5bca 
Signed-off-by: Stephen Rugh <rugh@adobe.com>
@sirugh sirugh added version: Minor This changeset includes functionality added in a backwards compatible manner. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jan 23, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 23, 2020 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-161.

Generated by 🚫 dangerJS against 651c23c

@sirugh sirugh added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jan 23, 2020
@sirugh
feedback
0d0fddb 
Signed-off-by: Stephen Rugh <rugh@adobe.com>
@dpatil-magento
Copy link
Contributor

@sirugh Be on 2nd page of sub-category and hit category breadcrumb link. Category breadcrumb should load 1st page but its defaulting to 2nd (Previous state)

@dpatil-magento
Copy link
Contributor

Above observation will be addressed as part of https://jira.corp.magento.com/browse/PWA-343

@dpatil-magento dpatil-magento merged commit 349f6e9 into develop Jan 30, 2020
@dpatil-magento dpatil-magento deleted the rugh/breadcrumbs-intermediate branch January 30, 2020 17:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@sirugh sirugh

@jimbo jimbo

Labels
pkg:peregrine pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirugh @PWAStudioBot @dpatil-magento @jimbo