Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Checkout Items Review Component #2257

Merged
merged 33 commits into from
Mar 26, 2020

Conversation

revanth0212
Copy link
Contributor

@revanth0212 revanth0212 commented Mar 17, 2020

Description

Created the review of items in order component.

Related Issue

Closes PWA-406

Verification Steps

  1. Add items to the cart.
  2. Go to the checkout page.
  3. Complete address and payment steps. You should see review of the items section before you place the order.

Screenshots / Screen Captures (if appropriate)

Desktop (Showing only 2):

image

Desktop (Showing All):

image

Mobile (Showing only 2):

image

Mobile (Showing All):

image

Checklist

None

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Mar 17, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 17, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-406.

Generated by 🚫 dangerJS against c9ea2e2

@revanth0212 revanth0212 marked this pull request as ready for review March 17, 2020 21:17
sirugh
sirugh previously approved these changes Mar 20, 2020
jimbo
jimbo previously approved these changes Mar 24, 2020
@soumya-ashok
Copy link

@revanth0212 - Listing the options how @jimbo suggested is fine. Let's keep that.
I am seeing a ton of space separating the second product from the horizontal rule below. In the mock I have 24px between them.

Additionally, if I go to the cart from the review step and return to checkout, the review order button shows up between the payment card and the items card. Maybe this is a caching issue as well? Not sure.

Screen Shot 2020-03-25 at 3 42 09 PM

@tjwiebell
Copy link
Contributor

@revanth0212 - This is very close to QA pass. Please see this comment about too much white space.

I am also still seeing SHOW ALL ITEMS regardless of my viewport size, which I believe is supposed to be mobile only. If that requirement didn't change, please investigate.

@jimbo
Copy link
Contributor

jimbo commented Mar 26, 2020

I am also still seeing SHOW ALL ITEMS regardless of my viewport size, which I believe is supposed to be mobile only. If that requirement didn't change, please investigate.

Personally I'd be fine with it on desktop as well.

@soumya-ashok
Copy link

@tjwiebell and @jimbo - "Show all items" is intended for all viewports. The default state would be to display up to 2 items with the option to see more if they exist.

@tjwiebell
Copy link
Contributor

@tjwiebell and @jimbo - "Show all items" is intended for all viewports. The default state would be to display up to 2 items with the option to see more if they exist.

@revanth0212 - I'm not sure where I pulled that requirement from then, sorry 😬Fix the white space problem and this is ready to merge.

@revanth0212
Copy link
Contributor Author

@tjwiebell and @jimbo - "Show all items" is intended for all viewports. The default state would be to display up to 2 items with the option to see more if they exist.

@revanth0212 - I'm not sure where I pulled that requirement from then, sorry 😬Fix the white space problem and this is ready to merge.

Hey @tjwiebell it will be handled in a different PR. You can merge this for now.

@revanth0212
Copy link
Contributor Author

The white space issue should be gone now. Also the animation can not be done for rectangle expansion. It can only be done for the visibility of the hidden items.

image

@soumya-ashok
Copy link

@revanth0212 and @jimbo UX approved

….css

Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
….css

Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
@tjwiebell tjwiebell merged commit 35ddc07 into develop Mar 26, 2020
@tjwiebell tjwiebell deleted the revanth/checkout_items_review_component branch March 26, 2020 23:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:peregrine pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants