-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Checkout Items Review Component #2257
Conversation
|
packages/peregrine/lib/talons/CheckoutPage/ItemsReview/useItemsReview.js
Outdated
Show resolved
Hide resolved
packages/peregrine/lib/talons/CheckoutPage/ItemsReview/useItemsReview.js
Show resolved
Hide resolved
packages/peregrine/lib/talons/CheckoutPage/ItemsReview/useItemsReview.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/ItemsReview/itemsReviewQuery.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/ItemsReview/itemsReviewQuery.js
Outdated
Show resolved
Hide resolved
…hub.com/magento/pwa-studio into revanth/checkout_items_review_component
@revanth0212 - Listing the options how @jimbo suggested is fine. Let's keep that. Additionally, if I go to the cart from the review step and return to checkout, the review order button shows up between the payment card and the items card. Maybe this is a caching issue as well? Not sure. |
@revanth0212 - This is very close to QA pass. Please see this comment about too much white space. I am also still seeing |
Personally I'd be fine with it on desktop as well. |
@tjwiebell and @jimbo - "Show all items" is intended for all viewports. The default state would be to display up to 2 items with the option to see more if they exist. |
@revanth0212 - I'm not sure where I pulled that requirement from then, sorry 😬Fix the white space problem and this is ready to merge. |
Hey @tjwiebell it will be handled in a different PR. You can merge this for now. |
@revanth0212 and @jimbo UX approved |
packages/venia-ui/lib/components/CheckoutPage/ItemsReview/item.css
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/ItemsReview/item.css
Outdated
Show resolved
Hide resolved
….css Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
….css Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>
Description
Created the review of items in order component.
Related Issue
Closes PWA-406
Verification Steps
Screenshots / Screen Captures (if appropriate)
Desktop (Showing only 2):
Desktop (Showing All):
Mobile (Showing only 2):
Mobile (Showing All):
Checklist
None