#2287: Fix for rounding error on src set #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpatil-magento
added
the
CI_APPROVED
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
tjwiebell
approved these changes
Apr 3, 2020
tjwiebell
added
the
version: Patch
jimbo
approved these changes
Apr 5, 2020
There was a problem hiding this comment.
@larsroettig Thanks for the contribution. Good catch here, and the fix looks straightforward.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for rounding issue #2287
Related Issue
Closes #2287
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist