Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Docs] Adding section to docs about SASS and LESS #2316

Merged
merged 6 commits into from
May 20, 2020
Merged

[Docs] Adding section to docs about SASS and LESS #2316

merged 6 commits into from
May 20, 2020

Conversation

LucasCalazans
Copy link
Member

@LucasCalazans LucasCalazans commented Apr 5, 2020 •
edited
Loading

Description

New devdocs section on the tutorials about how to configure SASS and LESS.

Related Issue

Closes #1759
Closes #1612

Acceptance

Verification Stakeholders

Specification

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly
  • I have added tests to cover my changes, if necessary.

@dpatil-magento dpatil-magento added the CI_APPROVED This PR should be included in the CI process. label Apr 6, 2020
@jcalcaben jcalcaben changed the title Adding section to docs about SASS and LESS [Docs] Adding section to docs about SASS and LESS Apr 6, 2020
@jcalcaben jcalcaben added docs documentation documentation This pertains to documentation. pkg:pwa-devdocs labels Apr 6, 2020
jcalcaben
jcalcaben requested changes Apr 6, 2020
View reviewed changes
pwa-devdocs/src/_data/tutorials.yml Outdated
@@ -20,6 +20,9 @@ entries:
- label: Create a TagList component
url: /tutorials/create-taglist-component/

- label: Configure SASS or LESS
url: /tutorials/configure-sass-less/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: /tutorials/configure-sass-less/
url: /tutorials/enable-sass-less-support/

Change the actual file name too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in 13a718d.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configure-sass-less directory needs to be changed to enable-sass-less-support so the navigation link doesn't break.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Apr 7, 2020 •
edited
Loading

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 3ecc22b

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label May 19, 2020
@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented May 19, 2020 •
edited
Loading

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2316.pwa-venia.com : LH Performance Expected 0.85 Actual 0.58, LH Best Practices Expected 1 Actual 0.92
https://pr-2316.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.35, LH Best Practices Expected 1 Actual 0.92
https://pr-2316.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.5, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@tjwiebell
Copy link
Contributor

@jcalcaben - Addressed your feedback, and updated code samples to some recent changes to webpack.config. LMK if there's anything else to get this merged.

jcalcaben
jcalcaben requested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@jcalcaben jcalcaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes so it passes the linter

@dpatil-magento
Copy link
Contributor

Ran yarn develop and verified new page exists.

@dpatil-magento dpatil-magento merged commit 99d9888 into magento:develop May 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tjwiebell tjwiebell tjwiebell left review comments

@jcalcaben jcalcaben jcalcaben approved these changes

Assignees

@tjwiebell tjwiebell

@jcalcaben jcalcaben

Labels
CI_APPROVED This PR should be included in the CI process. docs documentation documentation This pertains to documentation. Event: Global-Contribution-Day Groomed for GCD 2020 Partner: Webjump partners-contribution pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc]: Webpack less configuration [doc]: Webpack less configuration
7 participants
@LucasCalazans @PWAStudioBot @devops-pwa-codebuild @tjwiebell @dpatil-magento @jcalcaben @magento-engcom-team