update docker image

[dpatil-magento]

Description

Current docker image is too old and once #2298 is merged, build and deploy jobs will fail. Updated to near latest node 12 image.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. AWS build/deploy jobs should pass.
2. on local bash docker/run-docker should work.

Screenshots / Screen Captures (if appropriate)

Checklist

• I have updated the documentation accordingly, if necessary.
  [ ] I have added tests to cover my changes, if necessary.

[PWAStudioBot]

	Fails
🚫	No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
🚫	A version label is required. A maintainer must add one.

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 63285e4

[devops-pwa-codebuild]

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2406.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92
https://pr-2406.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.35, LH Best Practices Expected 1 Actual 0.92
https://pr-2406.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.51, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

[dpatil-magento]

Tested with #2298 changes in #2408

[fooman]

If #2298 breaks on node 10 shouldn't we also bump https://github.com/magento/pwa-studio/blob/develop/package.json#L89 to 12?

[dpatil-magento]

If #2298 breaks on node 10 shouldn't we also bump https://github.com/magento/pwa-studio/blob/develop/package.json#L89 to 12?

Specifically, Its node 10.14.1, which is too old. anything > 10.14.1 works.
error jest@26.0.1: The engine "node" is incompatible with this module. Expected version ">= 10.14.2". Got "10.14.1"

I also tested with 10.14.2 and it works c278552. Updating CI to node docker 12 to be more future proof.

[zetlen]

@dpatil-magento We could choose to declare what point-release ranges of LTS we support. It's not realistic for us to say we support all of 10.x, or all of 12.x, but we could choose a realistic set.

[zetlen]

LGTM, but I had one question about using an lts alias for easier future maintenance.

[zetlen]

Is it our policy to always specify an exact version when pulling the docker image? This could auto-update to the most recent LTS version if you used the alias node:lts-alpine.

[dpatil-magento]

We use exact working version to avoid any bugs in latest version might have. In this way our CI env would be more stable.

[dpatil-magento]

But I can have test pr to try node:lts-alpine and track it for 10-15 days and then discuss the outcomes.

[zetlen]

I understand that we're testing using an lts alias elsewhere. Meanwhile, LGTM!