-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PWA-513] Fix Dropdown arrows in Firefox #2455
Conversation
- Ensure dropdown arrows are always displayed in Firefox when auto complete is used
|
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2455.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying my comment from the other PR:
Makes sense. DOM order should normally be enough, but I can see how one browser or another could have trouble with ordering when one of the siblings is a replaced element.
QA approved |
Description
Ensure dropdown arrows are always displayed in Firefox when auto complete is used
Related Issue
https://jira.corp.magento.com/browse/PWA-513
Acceptance
Verification Stakeholders
@jimbo
@dhaecker
Specification
Verification Steps
Pre-condition - Test in Firefox browser
Steps -
Screenshots / Screen Captures (if appropriate)
Checklist