Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PWA-589] Page Reset on Sort #2458

Merged
merged 13 commits into from
Jun 12, 2020
Merged

[PWA-589] Page Reset on Sort #2458

merged 13 commits into from
Jun 12, 2020

Conversation

eug123
Copy link
Contributor

@eug123 eug123 commented Jun 4, 2020 •
edited
Loading

Description

If a customer changes the sort criteria they would be returned to the first 'page' of the newly sorted items.

Related Issue

https://jira.corp.magento.com/browse/PWA-589

Acceptance

Verification Stakeholders

@dhaecker
@jimbo

Specification

Verification Steps

  1. Go to a Category/Search results page
  2. Sort by Price: High to Low
  3. Go to page 2
  4. Change the sort to Price: Low to High
  5. See that you sent back to page 1

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 4, 2020 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-589.

Generated by 🚫 dangerJS against 72c6332

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 4, 2020 •
edited
Loading

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2458.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2458.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.36, LH Best Practices Expected 1 Actual 0.92
https://pr-2458.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.49, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@davemacaulay davemacaulay added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 5, 2020
jimbo
jimbo previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Use case makes sense and it works in my testing. 👍

tjwiebell
tjwiebell reviewed Jun 11, 2020
View reviewed changes
packages/peregrine/lib/talons/SearchPage/__tests__/useSearchPage.spec.js
]
];

test.each(testCases)(
Copy link
Contributor

@tjwiebell tjwiebell Jun 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me of DataProviders in PHPUnit and I think I like it. May just have to use this pattern in the next set of tests I write, looks awesome 👌

@eug123 eug123 requested review from tjwiebell and jimbo June 11, 2020 16:45
@dhaecker
Copy link
Collaborator

QA approved

@davemacaulay davemacaulay merged commit e91b345 into magento:develop Jun 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tjwiebell tjwiebell tjwiebell approved these changes

@jimbo jimbo jimbo approved these changes

Assignees

@tjwiebell tjwiebell

@jimbo jimbo

Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eug123 @PWAStudioBot @devops-pwa-codebuild @dhaecker @tjwiebell @jimbo @davemacaulay