Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs] Clarify Optional Sample Data #2474

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

tjwiebell
Copy link
Contributor

Description

re: https://magentocommeng.slack.com/archives/C71HNKYS2/p1591716658341100

Clarify that sample data is optional, reduce any confusion for first time installations that have their own data.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Verify my english is guud

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.

@tjwiebell tjwiebell requested a review from jcalcaben June 9, 2020 17:04
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 9, 2020

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 2534b1f

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 9, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2474.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92
https://pr-2474.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.36, LH Best Practices Expected 1 Actual 0.92
https://pr-2474.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.5, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@tjwiebell tjwiebell merged commit f866f54 into develop Jun 9, 2020
@tjwiebell tjwiebell deleted the docs/sample-data-change branch June 9, 2020 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants