Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove button clipping #2499

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Remove button clipping #2499

merged 2 commits into from
Jun 18, 2020

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Jun 18, 2020

Description

Recently, we allowed a change to reach develop, which causes buttons to clip their text when it overflows. That's not actually the behavior we want (clipped text is useless on a button), and it has some unfortunate side effects. Text wrapping will be handled soon in an upcoming PR, but for now, we're removing the clipping.

Related Issue

PWA-693

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Open any view with a button.
  2. Verify that no part of the text is clipped.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jimbo jimbo added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 18, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 18, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-693.

Generated by 🚫 dangerJS against 669e2b5

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 18, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2499.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92
https://pr-2499.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.37, LH Best Practices Expected 1 Actual 0.92
https://pr-2499.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.48, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@dpatil-magento
Copy link
Contributor

QA Pass.

@dpatil-magento dpatil-magento merged commit f6c386e into develop Jun 18, 2020
@dpatil-magento dpatil-magento deleted the jimbo/button-overflow branch June 18, 2020 21:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants