Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update home page route #2565

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Update home page route #2565

merged 1 commit into from
Jul 20, 2020

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Jul 17, 2020 •
edited
Loading

Description

Update the home page route from /venia-new-home to /. This approach is still not ideal.

Related Issue

PWA-769

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Ensure the home page has been set on the backend.
  2. Go to the home page.
  3. Verify the page is styled correctly.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jimbo jimbo added version: Minor This changeset includes functionality added in a backwards compatible manner. version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jul 17, 2020
@jimbo jimbo marked this pull request as ready for review July 17, 2020 16:54
davemacaulay
davemacaulay previously approved these changes Jul 17, 2020
View reviewed changes
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jul 17, 2020 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-769.

Generated by 🚫 dangerJS against 598db9a

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jul 17, 2020 •
edited
Loading

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2565.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2565.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.37, LH Best Practices Expected 1 Actual 0.92
https://pr-2565.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.49, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@dpatil-magento dpatil-magento changed the base branch from develop to release/7.0 July 20, 2020 16:04
@dpatil-magento dpatil-magento dismissed davemacaulay’s stale review July 20, 2020 16:04

The base branch was changed.

@dpatil-magento dpatil-magento changed the base branch from release/7.0 to develop July 20, 2020 16:04
@dpatil-magento
Copy link
Contributor

@jimbo This PR should be against release/7.0 , I tried updating but needs to be rebased.

@tjwiebell tjwiebell changed the base branch from develop to release/7.0 July 20, 2020 16:15
@jcalcaben jcalcaben mentioned this pull request Jul 20, 2020
Merged
1 task
@dpatil-magento dpatil-magento merged commit 702379a into release/7.0 Jul 20, 2020
@dpatil-magento dpatil-magento deleted the jimbo/home-route branch July 20, 2020 20:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tjwiebell tjwiebell tjwiebell approved these changes

@davemacaulay davemacaulay davemacaulay approved these changes

Assignees

@tjwiebell tjwiebell

@davemacaulay davemacaulay

Labels
pkg:venia-ui version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jimbo @PWAStudioBot @devops-pwa-codebuild @dpatil-magento @tjwiebell @davemacaulay