Create a new Target for RichContentTypes (data-content-type=) #2968

[0m3r]

Description

It gets the possibility for an extension to add custom content type renderers.

https://github.com/magento/pwa-studio/blob/develop/packages/pagebuilder/lib/config.js#L29

Related Issue

#2130
#2131
#2968

Closes #2968

Acceptance

@sirugh
@zetlen

Verification Steps

intercept.js

    targets
        .of('@magento/venia-ui')
        .richContentTypes.tap(contentTypes => {
            contentTypes.add({
                contentType: 'XSlider',
                importPath: require.resolve(
                    "../lib/components/XSlider/ContentTypes/XSlider/index.js"
                )
            });
        });

lib/components/XSlider/ContentTypes/XSlider/index.js

import Component from './xslider';
import configAggregator from './configAggregator';

export default {
    name: 'xslider',
    configAggregator,
    component: Component
}

[PWAStudioBot]

	Fails
🚫	node` failed.
🚫	A version label is required. A maintainer must add one.
🚫	The following file(s) were not formatted with prettier. Make sure to execute yarn run prettier locally prior to committing. packages/venia-ui/lib/components/RichContent/richContent.js packages/venia-ui/lib/targets/RichContentTypeList.js

	Messages
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck

Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against ddda01a

[larsroettig]

We can not couple our theme with a standalone extension. From my point of view pagebuilder should have an extension point to inject local components into the page builder. There we need to mutch better API also maybe a Partner/Agency would overwrite the slider via this extension point. Currently, it is not possible to register a target on page builder it self so we need to create a story in our backlog.

[larsroettig]

❌ Needs SPIKE ticket for an API de# the core

Thank you for your contribution @0m3r unfortunately I cannot approve it because cycle dependency page builder is not a must-have for venia to work correctly.

If you want, you can create a new PR with no cycle. From my point of view, the core team need to handle it with a Spike or Poc.

Kind regards,

Lars

[0m3r]

Ok I will try to create a new PR