Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AC-2792::Common inputs lack autocomplete attributes (pattern) #3785

Merged
merged 3 commits into from
Jul 14, 2022
Merged

AC-2792::Common inputs lack autocomplete attributes (pattern) #3785

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fcce6a
AC-2792::Common inputs lack autocomplete attributes (pattern)
glo71317 Apr 26, 2022
be66dc4
AC-AC-2792:Resolve internationalisation all strings should be transla…
glo71317 May 2, 2022
e72407d
Merge branch 'develop' into AC-2792_v1
dpatil-magento Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/extensions/venia-sample-language-packs/i18n/fr_FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@
"shippingForm.getShippingOptions": "Obtenez les options d'expédition",
"shippingForm.loading": "Chargement des méthodes ...",
"shippingForm.zip": "Code postal",
"shippingForm.shippingEmail":"Livraison Courriel",
"shippingInformation.cardTitle": "Informations sur l'expedition",
"shippingInformation.editTitle": "1. Informations d'expédition",
"shippingInformation.loading": "Récupération des informations d'expédition...",
Expand Down
1 change: 1 addition & 0 deletions packages/venia-ui/i18n/en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@
"shippingForm.getShippingOptions": "Get Shipping Options",
"shippingForm.loading": "Loading Methods...",
"shippingForm.zip": "ZIP",
"shippingForm.shippingEmail":"Shipping Email",
"shippingInformation.cardTitle": "Shipping Information",
"shippingInformation.editTitle": "1. Shipping Information",
"shippingInformation.loading": "Fetching Shipping Information...",
Expand Down
44 changes: 40 additions & 4 deletions ...eckoutPage/ShippingInformation/AddressForm/__tests__/__snapshots__/guestForm.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Array [
className="input"
>
<input
autoComplete="off"
autoComplete="Shipping Email"
className="input"
id="email"
name="email"
Expand Down Expand Up @@ -91,6 +91,7 @@ Array [
className="input"
>
<input
autoComplete="First Name"
className="input"
id="firstname"
name="firstname"
Expand Down Expand Up @@ -136,6 +137,7 @@ Array [
className="input"
>
<input
autoComplete="Last Name"
className="input"
id="lastname"
name="lastname"
Expand All @@ -160,6 +162,7 @@ Array [
className="country"
>
<Country
autoComplete="Country"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -188,6 +191,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address"
className="input"
id="street0"
name="street[0]"
Expand Down Expand Up @@ -241,6 +245,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address 2"
className="input"
id="street1"
name="street[1]"
Expand Down Expand Up @@ -286,6 +291,7 @@ Array [
className="input"
>
<input
autoComplete="City"
className="input"
id="city"
name="city"
Expand All @@ -310,6 +316,7 @@ Array [
className="region"
>
<Region
autoComplete="State"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -341,6 +348,7 @@ Array [
className="input"
>
<input
autoComplete="ZIP / Postal Code"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -386,6 +394,7 @@ Array [
className="input"
>
<input
autoComplete="Phone Number"
className="input"
id="telephone"
name="telephone"
Expand Down Expand Up @@ -477,7 +486,7 @@ Array [
className="input"
>
<input
autoComplete="off"
autoComplete="Shipping Email"
className="input"
id="email"
name="email"
Expand Down Expand Up @@ -532,6 +541,7 @@ Array [
className="input"
>
<input
autoComplete="First Name"
className="input"
id="firstname"
name="firstname"
Expand Down Expand Up @@ -577,6 +587,7 @@ Array [
className="input"
>
<input
autoComplete="Last Name"
className="input"
id="lastname"
name="lastname"
Expand All @@ -601,6 +612,7 @@ Array [
className="country"
>
<Country
autoComplete="Country"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -629,6 +641,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address"
className="input"
id="street0"
name="street[0]"
Expand Down Expand Up @@ -682,6 +695,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address 2"
className="input"
id="street1"
name="street[1]"
Expand Down Expand Up @@ -727,6 +741,7 @@ Array [
className="input"
>
<input
autoComplete="City"
className="input"
id="city"
name="city"
Expand All @@ -751,6 +766,7 @@ Array [
className="region"
>
<Region
autoComplete="State"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -782,6 +798,7 @@ Array [
className="input"
>
<input
autoComplete="ZIP / Postal Code"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -827,6 +844,7 @@ Array [
className="input"
>
<input
autoComplete="Phone Number"
className="input"
id="telephone"
name="telephone"
Expand Down Expand Up @@ -914,7 +932,7 @@ Array [
className="input"
>
<input
autoComplete="off"
autoComplete="Shipping Email"
className="input"
id="email"
name="email"
Expand Down Expand Up @@ -961,6 +979,7 @@ Array [
className="input"
>
<input
autoComplete="First Name"
className="input"
id="firstname"
name="firstname"
Expand Down Expand Up @@ -1006,6 +1025,7 @@ Array [
className="input"
>
<input
autoComplete="Last Name"
className="input"
id="lastname"
name="lastname"
Expand All @@ -1030,6 +1050,7 @@ Array [
className="country"
>
<Country
autoComplete="Country"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -1058,6 +1079,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address"
className="input"
id="street0"
name="street[0]"
Expand Down Expand Up @@ -1111,6 +1133,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address 2"
className="input"
id="street1"
name="street[1]"
Expand Down Expand Up @@ -1156,6 +1179,7 @@ Array [
className="input"
>
<input
autoComplete="City"
className="input"
id="city"
name="city"
Expand All @@ -1180,6 +1204,7 @@ Array [
className="region"
>
<Region
autoComplete="State"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -1211,6 +1236,7 @@ Array [
className="input"
>
<input
autoComplete="ZIP / Postal Code"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -1256,6 +1282,7 @@ Array [
className="input"
>
<input
autoComplete="Phone Number"
className="input"
id="telephone"
name="telephone"
Expand Down Expand Up @@ -1369,7 +1396,7 @@ Array [
className="input"
>
<input
autoComplete="off"
autoComplete="Shipping Email"
className="input"
id="email"
name="email"
Expand Down Expand Up @@ -1416,6 +1443,7 @@ Array [
className="input"
>
<input
autoComplete="First Name"
className="input"
id="firstname"
name="firstname"
Expand Down Expand Up @@ -1461,6 +1489,7 @@ Array [
className="input"
>
<input
autoComplete="Last Name"
className="input"
id="lastname"
name="lastname"
Expand All @@ -1485,6 +1514,7 @@ Array [
className="country"
>
<Country
autoComplete="Country"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -1513,6 +1543,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address"
className="input"
id="street0"
name="street[0]"
Expand Down Expand Up @@ -1566,6 +1597,7 @@ Array [
className="input"
>
<input
autoComplete="Street Address 2"
className="input"
id="street1"
name="street[1]"
Expand Down Expand Up @@ -1611,6 +1643,7 @@ Array [
className="input"
>
<input
autoComplete="City"
className="input"
id="city"
name="city"
Expand All @@ -1635,6 +1668,7 @@ Array [
className="region"
>
<Region
autoComplete="State"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -1666,6 +1700,7 @@ Array [
className="input"
>
<input
autoComplete="ZIP / Postal Code"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -1711,6 +1746,7 @@ Array [
className="input"
>
<input
autoComplete="Phone Number"
className="input"
id="telephone"
name="telephone"
Expand Down
Loading