Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bugfix] Fix broken or unreliable cypress tests #3911

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

jcalcaben
Copy link
Contributor

Description

Fixes potentially broken or unreliable cypress tests.

Related Issue

Closes PWA-2949

Acceptance

any core developer

Verification Stakeholders

any core developer
@dpatil-magento

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jcalcaben jcalcaben added the version: Patch This changeset includes backwards compatible bug fixes. label Jul 21, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 21, 2022

Messages
📖

Associated JIRA tickets: PWA-2949.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 3d7b3ff

@jcalcaben jcalcaben marked this pull request as ready for review July 21, 2022 19:36
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 22, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 22, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress @snapshot

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 22, 2022

Successfully started codebuild job for cypress with tags @snapshot

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 3d7b3ff

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 58580c3 into develop Jul 22, 2022
@dpatil-magento dpatil-magento deleted the PWA-2949/cypress-test-fixes branch July 22, 2022 18:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants