Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PWA-2971: [bug]: Gallery item Add To Cart configurable product redire… #4001

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

anthoula
Copy link
Contributor

…ct URL doesn't match tile URL

  • prefix url suffix with slash to fix redirect
  • update test expectation

Description

Prefix URL with a / so it uses the base URL instead of being relative

Related Issue

Closes #3854.

Acceptance

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…ct URL doesn't match tile URL

- prefix url suffix with slash to fix redirect
- update test expectation
@anthoula anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 10, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 10, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6e959ee

…ct URL doesn't match tile URL

- use resourceUrl util to generate redirect link
@anthoula
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 10, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • User shouldn't be able to add a CustomizableProduct from category page:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetProductDetailForProductPageQuery`. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 6e959ee

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 11, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 11, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento
Copy link
Contributor

QA Approved.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Gallery item Add To Cart configurable product redirect URL doesn't match tile URL
4 participants