Bug#pwa 3025

[RaghavendraTirumalasetti]

Description

On a mobile device or desktop, when clicking on the text of a specific filter, it doesn't select the filter. For it to work properly, you have to specifically press on the checkbox.

To reproduce

Steps to reproduce the behavior:

Go to http://develop.pwa-venia.com/default/venia-tops.html?page=1
Expand any filter group
Click on the text label (not the checkbox itself) to apply a filter
Witness the problem: the filter doesn't get selected (it used to)
Expected behavior

When pressing or clicking on the text label beside the filter checkbox, the filter should be applied exactly as if I have explicitly clicked on the filter checkbox. The full line should be responsive to the selection (not only the checkbox part)

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3025.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

[pwa-studio-bot]

	Fails
🚫	A version label is required. A maintainer must add one.

	Messages
📖	Associated JIRA tickets: PWA-3025.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 35b0b33

[glo42707]

run cypress

[pwa-test-bot]

Successfully started codebuild job for cypress

[pwa-studio-bot]

	Fails
🚫	node failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to add and remove promotions from cart: AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found. user should be able to update their address book: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests

Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 35b0b33