Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

3230 Sign-in broken following 13.3.0 #4221

Merged
merged 9 commits into from
Mar 12, 2024
Merged

3230 Sign-in broken following 13.3.0 #4221

merged 9 commits into from
Mar 12, 2024

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

TODO: Login no longer works following 13.3.0. This is also visible on venia.magento.com

To reproduce

Steps to reproduce the behavior:

  • Open Sign-in dropdown in menu
  • Enter credentials
  • Try to #
  • Dropdown will close without doing anything else
  • Go to /sign-in page
  • Enter credentials
  • Try to #
  • Button will be grayed out (error in console)

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3230.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 21, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3230.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against c15833b

@glo82145 glo82145 self-requested a review March 12, 2024 05:39
@glo82145 glo82145 merged commit b457789 into develop Mar 12, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants