Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PWA Product Recommendation venia #4283

Merged
merged 11 commits into from
Jun 27, 2024
Merged

PWA Product Recommendation venia #4283

merged 11 commits into from
Jun 27, 2024

Conversation

glo82145
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 24, 2024

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against cc91b64

@glo82145
Copy link
Collaborator Author

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 26, 2024

Successfully started codebuild job for scaffold-pwa

@glo82145
Copy link
Collaborator Author

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 26, 2024

Successfully started codebuild job for pr-deploy

@glo82145 glo82145 force-pushed the Product_recommend branch from 10307ab to 199b660 Compare June 26, 2024 10:49
@glo82145
Copy link
Collaborator Author

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 26, 2024

Successfully started codebuild job for pr-test

@glo82145 glo82145 force-pushed the Product_recommend branch from 21c3994 to 199b660 Compare June 26, 2024 13:52
@glo82145
Copy link
Collaborator Author

run pr-build

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 26, 2024

Successfully started codebuild job for pr-build

@glo82145 glo82145 force-pushed the Product_recommend branch from 450a4bd to 199b660 Compare June 27, 2024 07:55
@glo82145
Copy link
Collaborator Author

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 27, 2024

Successfully started codebuild job for scaffold-pwa

@glo82145
Copy link
Collaborator Author

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 27, 2024

Successfully started codebuild job for pr-test

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo82145 glo82145 merged commit 2411b31 into develop Jun 27, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants